Skip to content

solution for issue #55 #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 2, 2021
Merged

solution for issue #55 #56

merged 1 commit into from
Oct 2, 2021

Conversation

@sreyan-ghosh
Copy link
Contributor

@sreyan-ghosh sreyan-ghosh commented Sep 30, 2021 •
edited by DrGFreeman
Loading

Fixes #55 completely.

Changes Made

  1. Changed indentation as per this issue
  2. Changes were made to the dynamo_pandas.py file where incorrect indentation was changed.

NOTE

  1. Please consider this PR as a submission towards Hacktoberfest 2021 and add the hacktoberfest-accepted label to it.
  2. Hacktoberfest 2021 has started as of now globally due to a bug in the timing algorithm so you can merge the PR now and it will still count. Cheers.

@sreyan-ghosh
solution for issue DrGFreeman#55
68d9c2f 
changed indentation as per this [issue](DrGFreeman#55)
@DrGFreeman
Copy link
Owner

DrGFreeman commented Oct 2, 2021

Looks good. Thank you @sreyan-ghosh!

@DrGFreeman DrGFreeman merged commit 5b3f684 into DrGFreeman:main Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

hacktoberfest-accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad indentation in get_df docs dtype example

2 participants

@sreyan-ghosh @DrGFreeman