-
Notifications
You must be signed in to change notification settings - Fork 0
Adding vars inherit secrets #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @alexandremac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request enhances the GMUD creation action by allowing the Slack bot token and channel to be passed in as inputs, rather than relying on secrets. It also removes the branch restriction on sending Slack notifications, ensuring they are always sent.
Highlights
- Inputs: Added
slack-bot-user-oauth-access-tokenandslack-channelas inputs to the action, allowing these values to be passed in rather than hardcoded or relying on secrets. - Slack Notification: Modified the
Send GMUD payload notificationstep to use the inputslack-bot-user-oauth-access-tokeninstead of thesecrets.SLACK_NOBOT_TOKENsecret. - Conditional Execution: Removed the
if: ${{ github.ref_name == 'main' }}condition from theSend GMUD payload notificationstep, so that the notification is sent regardless of the branch.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request introduces new inputs for Slack notifications, which is a good step towards making the action more configurable. However, it removes a condition that previously limited notifications to the main branch and fails to utilize the newly added slack-channel input, leaving it hardcoded. These points should be addressed to ensure the action behaves as intended and is fully flexible.
| with: | ||
| slack-bot-user-oauth-access-token: ${{ secrets.SLACK_NOBOT_TOKEN }} | ||
| slack-bot-user-oauth-access-token: ${{ inputs.slack-bot-user-oauth-access-token }} | ||
| slack-channel: 'C093VDRV5CP' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.