Skip to content

Conversation

@alexandremac
Copy link

No description provided.

@alexandremac alexandremac requested a review from a team July 3, 2025 16:47
@alexandremac alexandremac self-assigned this Jul 3, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @alexandremac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the GMUD creation action by allowing the Slack bot token and channel to be passed in as inputs, rather than relying on secrets. It also removes the branch restriction on sending Slack notifications, ensuring they are always sent.

Highlights

  • Inputs: Added slack-bot-user-oauth-access-token and slack-channel as inputs to the action, allowing these values to be passed in rather than hardcoded or relying on secrets.
  • Slack Notification: Modified the Send GMUD payload notification step to use the input slack-bot-user-oauth-access-token instead of the secrets.SLACK_NOBOT_TOKEN secret.
  • Conditional Execution: Removed the if: ${{ github.ref_name == 'main' }} condition from the Send GMUD payload notification step, so that the notification is sent regardless of the branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces new inputs for Slack notifications, which is a good step towards making the action more configurable. However, it removes a condition that previously limited notifications to the main branch and fails to utilize the newly added slack-channel input, leaving it hardcoded. These points should be addressed to ensure the action behaves as intended and is fully flexible.

with:
slack-bot-user-oauth-access-token: ${{ secrets.SLACK_NOBOT_TOKEN }}
slack-bot-user-oauth-access-token: ${{ inputs.slack-bot-user-oauth-access-token }}
slack-channel: 'C093VDRV5CP'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The slack-channel input was correctly added in the inputs section (lines 17-19), but it is still hardcoded here. To fully leverage the new input and make the action more flexible and reusable, please use inputs.slack-channel instead of the hardcoded value.

slack-channel: ${{ inputs.slack-channel }}

@alexandremac alexandremac merged commit 563498a into main Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants