-
Notifications
You must be signed in to change notification settings - Fork 0
Adding Slack Test channel #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @alexandremac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly enhances the automated GMUD (Gerenciamento de Mudanças - Change Management) creation workflow. It introduces a mechanism to capture and display whether a change has been tested in a homologation environment directly within the generated GMUD. Furthermore, it implements a new Slack notification system that alerts a designated channel (likely a test channel) whenever a new GMUD is successfully created, providing quick access to both the GLPI ticket and the associated GitHub Pull Request.
Highlights
- PR Body Parsing for 'Tested' Status: The workflow now extracts a 'tested' confirmation ('Sim' or 'Não') from the pull request body, based on the presence of
[x] **Confirmo**. - GMUD Content Enrichment: The extracted 'tested' status is now included as a dedicated field within the generated GMUD content, providing clearer visibility on testing.
- GMUD Naming Convention Update: The naming convention for the generated GMUD has been updated to use the GitHub repository name (
github.repository) instead of the previously extracted 'Serviço Afetado' (Affected Service). - Automated Slack Notifications: A new step has been added to send a structured Slack notification to channel
C093VDRV5CPupon successful GMUD creation, specifically when merged to themainbranch. - Direct GLPI and GitHub Links in Slack: The Slack notification includes actionable buttons to directly open the newly created GMUD in GLPI (using its extracted ID) and to view the associated GitHub Pull Request.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new feature to send a Slack notification when a GMUD is created. It also introduces a check for whether the changes have been tested in a staging environment. The changes are mostly well-implemented, but I have identified a few areas for improvement regarding maintainability and security.
|
|
||
| - name: Send GMUD payload notification | ||
| if: ${{ github.ref_name == 'main' }} | ||
| uses: archive/github-actions-slack@v2.9.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| uses: archive/github-actions-slack@v2.9.0 | ||
| with: | ||
| slack-bot-user-oauth-access-token: ${{ secrets.SLACK_NOBOT_TOKEN }} | ||
| slack-channel: 'C093VDRV5CP' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check "testado" and add slack msg