Moved cursor.ToListAsync inside transaction, as required for Neo4J 4.… #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…x. Also sorted out some nulls in bookmarks.
|
I was encountering https://github.com/neo4j/neo4j-dotnet-driver/issues/380 issue using the latest prerelease, so as suggested on the issue, I've moved the collection of results to the inside of the transaction call. I've sanity checked it against a live Neo4J 4.1 and it works both inside and outside a transaction. Inside a transaction (with no bookmarks declared) I was hitting NullReferenceExceptions, so I've cleared those up as well. @cskardon If you're happy with this, please could we have another prerelease with it? |
|
Yep, I'm happy largely as it's what I'd just been doing, I'll pull this in then add a few changes so it aligns with mine :) |
|
Awesome. Thanks! |
|
So this is Thanks for doing this! |
cskardon
pushed a commit
that referenced
this pull request
Sep 3, 2020
…x. Also sorted out some nulls in bookmarks. (#362)
cskardon
pushed a commit
that referenced
this pull request
Sep 5, 2020
…x. Also sorted out some nulls in bookmarks. (#362)
cskardon
pushed a commit
that referenced
this pull request
Sep 18, 2020
* change bolt client to use async endpoints of driver * accidental change * restructure solution for dotnet standard only * remove all sync endpoints, move everything to async (except transactions), and delete gremlin * add transactions * transactions tests * cleanup a couple of things * Multi-targeting 4.5.2, 4.6 as well as netstandard 2.0 now Added build constants for net45, and added the VB tests back in Adding Version into the csproj for CI * Updating the Readme * It will build - but not tested. DO NOT USE. * Preventing NCrunch solution files being committed * Parameters all use $ syntax now * Fixing some tests - more to go - mocking issues atm * Removed a lot of REST/Gremlin code from the GraphClient * `GraphClient` and `BoltGraphClient` currently connect against `4.0` Need to test GC with 3.5 - as no longer using `cypher` endpoint for anything, only tx * Majority of tests fixed, 3 to go * Tests fixed * update neo4j driver and add support for new signed and self-signed sc… (#356) * update neo4j driver and add support for new signed and self-signed schemes * update readme * Moved cursor.ToListAsync inside transaction, as required for Neo4J 4.x. Also sorted out some nulls in bookmarks. (#362) * Updating so the `Http` and `Bolt` versions work (#363) * Transactions and WithDatabase (#367) * Handling Encryption * Transactional 'WithDatabase' * Fix #386 on 4.x (#372) * Adding `USE` to the CypherFluentQuery * 40 development (#374) * Tests for Transactions Throws exceptions when cypher gives back errors This is now for the 'ExecuteCypherNoResults' side of things QueryStats for GraphClient - ExecuteNoResults 3.5 / 4.x * WithQueryStats for GraphClient * WithQueryStats for BoltGraphClient * Manual implementation of 'Neo4jIgnoreAttribute' To take into account changes since the PR was originally written by https://github.com/Clooney24 * 40 development (#375) * Remove `Start` * Create(string, params object[]) * Return<T>(string, CypherResultMode) * StartBit (various) * Mapper * Hiding unused member * Database Administration Commands * Set capabilities properly * Updating Readme Co-authored-by: Toby Miller <tobycmiller@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…x. Also sorted out some nulls in bookmarks.