Skip to content

Add vota-sf doc #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2024
Merged

Add vota-sf doc #154

merged 3 commits into from
May 31, 2024

Conversation

VegeBun-csj
Copy link
Collaborator

No description provided.

Comment on lines 96 to 101
curl https://df-node-dump.s3.ap-southeast-1.amazonaws.com/dora_sf_18222.tar.lz4 | lz4 -dc - | tar -xf - -C $HOME/.dora
<Tabs.Tab>
```shell

```
</Tabs.Tab>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里第 96 行应该放到 99 行的位置?

@@ -51,12 +58,17 @@ There are several public resources available for development.
vota-testnet-grpc.dorafactory.org:443
```
</Tabs.Tab>
<Tabs.Tab>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这行的缩进可以确认一下,最好能在本地用 prettier 控制一下代码格式

@@ -35,12 +37,17 @@ There are several public resources available for development.
https://vota-testnet-rpc.dorafactory.org:443
```
</Tabs.Tab>
<Tabs.Tab>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

缩进可以确认下

@VegeBun-csj VegeBun-csj merged commit 9faf36f into main May 31, 2024
@VegeBun-csj VegeBun-csj deleted the vota-sf-doc branch May 31, 2024 10:49
@@ -86,7 +91,7 @@ To instate a Dora Vota node, the first step is to [download and install `dorad`]
### Init commands

{/* prettier-ignore */}
<Tabs items={['Mainnet', 'Testnet']}>
<Tabs items={['Mainnet', 'Testnet', Incentivized Testnet]}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里字符串漏了引号?

@VegeBun-csj VegeBun-csj restored the vota-sf-doc branch May 31, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants