-
Notifications
You must be signed in to change notification settings - Fork 66
Move synth charging to the stomach, implement wind-up key and synth charging method prefs #833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
charging yourself is unintended behaviour, oops |
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
woe |

About The Pull Request
In this PR we entirely move synth charging to be on the stomach instead of the species, allow them to pick which stomach type they use, and add a wind-up key as a secondary option.
We broadly clean up the charging code somewhat in doing this.
We also unify the charge values, making all of them depend on the basic max charge.
The wind-up key requires a second person to charge, who needs to stand behind you to do this.
Why It's Good For The Game
Mechanics tied to the species are largely uninteractive ingame. The less things tied to things you can't interact with the better.
This allows you to make the questionable life choice of implanting a wind-up key or power cord into any other species and have it Just Work, much like ethereal stomachs. Or, for that matter, implement other charging mechanics for synths.
haha funny wind-up key go click click spinny
Testing Evidence
Changelog
🆑
refactor: Reworked synthetic species charging entirely. Please report any issues.
add: Added a wind-up key stomach replacement, requiring others to charge it for you.
add: Synthetic species can now pick their charging method, currently limited to power cord or wind-up key.
balance: Charging mechanics and lack of hunger are no longer inherent to the synthetic species, but tied to their stomach. You can find these as a medical design besides tier 2 cybernetic organs like their previous stomach.
balance: Synthetic charging rate has been very slightly altered.
balance: Synthetic will now lose some charge and spark on getting EMP'd, except for the wind-up key which is immune.
fix: Reviving someone with synthetic charging mechanics now always puts them up to 0.5MJ instead of sometimes going over.
del: Revival surgery no longer re-charges synths twice.
/:cl: