Skip to content

Conversation

@beeperoil
Copy link

About The Pull Request

  1. Sorting the loadout into subgroups so that browsing is more manageable and cohesive.

- Equipment/Tools, Health, Storage, Drugs, Tech, Recreational, Drinks/Food, Cosmetics, and Miscellaneous.

  1. Renaming items within the loadout so they are easier to search for and are easier to group with like-items within their subcategories.

- Renamed the equipment straps to Equipment Strap (Deparment).
- Renamed the knives to Knife (Type).
- Renamed the lighters to Lighter (Type).
- Renamed the PDAs to PDA(Type).
- Renamed the card decks to Card Deck(Type).
- Renamed the pens to Pen (Type).
- Renamed the six-packs to Six-Pack (Type).
- Renamed the mugs to Mug (Type).
- Renamed the lipsticks to Lipstick (Color).

Why It's Good For The Game

This will make the loadout look neater, cleaner, and more visually appealing as well as provide more functionality when it comes to searching.

Testing Evidence

image image image image image image image image image

Changelog

🆑
qol: Splits the items loadout category into subgroups: equipment/tools, storage, health, drugs, recreational, drinks/food, cosmetics, tech, and miscellaneous.
qol: Renames some of the loadout item entries in the items section for easier searching and aesthetic.
/:cl:

@github-actions github-actions bot added the Quality of Life Makes life a little bit easier. label Nov 13, 2025
@beeperoil beeperoil marked this pull request as draft November 15, 2025 17:31
@beeperoil beeperoil marked this pull request as ready for review November 17, 2025 20:12
Copy link
Collaborator

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

havent looked at the rest yet, nitpicks

@github-actions github-actions bot requested a review from 00-Steven November 20, 2025 19:00
@beeperoil
Copy link
Author

ill get to this soooon

Copy link
Collaborator

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seem to have accidentally un-uncommented the majority of the base TG pocket items, leading to a lot of duplicates and causing it to fail tests

@00-Steven 00-Steven marked this pull request as draft November 23, 2025 17:31
@beeperoil beeperoil marked this pull request as ready for review November 24, 2025 23:19
@github-actions github-actions bot requested a review from 00-Steven November 24, 2025 23:19
Copy link
Collaborator

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

procs for a specific loadout entry should go below that loadout entry in the file, so it's clearer that entry has something special going on
still need to go through the full pockets.dm file, but to note for later reviews: missed nothing from the base tg loadout folder

Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com>
Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
@github-actions github-actions bot requested a review from 00-Steven November 27, 2025 01:35
Copy link
Collaborator

@00-Steven 00-Steven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides those, gonna have to update the pr to master to fix the linters- they're not your fault but it's fixed on master

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

@github-actions github-actions bot added the Stale label Dec 5, 2025
@kannthus kannthus added No Stale Overrules the github stale actions. and removed Stale labels Dec 5, 2025
@github-actions github-actions bot requested a review from 00-Steven December 18, 2025 21:37
@beeperoil
Copy link
Author

unsure if i did that right :,) ima draft this for now

@beeperoil beeperoil marked this pull request as draft December 18, 2025 21:37
@beeperoil
Copy link
Author

actually it might be fine ya

@beeperoil beeperoil marked this pull request as ready for review December 19, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Stale Overrules the github stale actions. Quality of Life Makes life a little bit easier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants