-
Notifications
You must be signed in to change notification settings - Fork 66
Organizing the Loadout: Items #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Organizing the Loadout: Items #810
Conversation
00-Steven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
havent looked at the rest yet, nitpicks
|
ill get to this soooon |
00-Steven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you seem to have accidentally un-uncommented the majority of the base TG pocket items, leading to a lot of duplicates and causing it to fail tests
00-Steven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
procs for a specific loadout entry should go below that loadout entry in the file, so it's clearer that entry has something special going on
still need to go through the full pockets.dm file, but to note for later reviews: missed nothing from the base tg loadout folder
Co-authored-by: _0Steven <42909981+00-Steven@users.noreply.github.com> Signed-off-by: kirieiki <53238276+beeperoil@users.noreply.github.com>
00-Steven
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides those, gonna have to update the pr to master to fix the linters- they're not your fault but it's fixed on master
|
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
|
unsure if i did that right :,) ima draft this for now |
|
actually it might be fine ya |
About The Pull Request
- Equipment/Tools, Health, Storage, Drugs, Tech, Recreational, Drinks/Food, Cosmetics, and Miscellaneous.
- Renamed the equipment straps to Equipment Strap (Deparment).
- Renamed the knives to Knife (Type).
- Renamed the lighters to Lighter (Type).
- Renamed the PDAs to PDA(Type).
- Renamed the card decks to Card Deck(Type).
- Renamed the pens to Pen (Type).
- Renamed the six-packs to Six-Pack (Type).
- Renamed the mugs to Mug (Type).
- Renamed the lipsticks to Lipstick (Color).
Why It's Good For The Game
This will make the loadout look neater, cleaner, and more visually appealing as well as provide more functionality when it comes to searching.
Testing Evidence
Changelog
🆑
qol: Splits the items loadout category into subgroups: equipment/tools, storage, health, drugs, recreational, drinks/food, cosmetics, tech, and miscellaneous.
qol: Renames some of the loadout item entries in the items section for easier searching and aesthetic.
/:cl: