[BOUNTY] [TEST-MERGE ONLY] Teshari #787

nikothedude · 2025-10-31T00:02:02Z

About The Pull Request

Teshari! The loved and hated bids from nova and co.

This is mostly just a straight port. The same sprites, same mechanics, same everything. Theres only a few differences.

Only teshari can access their ears - this is because teshari ears just DONT work off teshari. (Tails can be accessed by anyone and tesh can pick non-tesh tails, thanks to how a lot of tails are laid out)
Teshari tablerunning is bound to a free-use ability, at the request of the client

Design doc: https://hackmd.io/@bboHcH7iQpC5t0gFmxs9EA/Hy9xPpNRxg

Bundled in this PR are a lot of changes and tweaks, mainly around our bodyshape-bound clothing code. Included is also a robust sprite autogen system, if we ever add a species like this again.

Why It's Good For The Game

Teshari have been mentioned as a potential port species from the very onset of the server, and they have rare mentions in the lore pages, but no efforts to fully port them were made until now. This widens the biodiversity of the selection of species we offer, allowing for players to select a well-known and frequently requested species that is non-humanoid, as well as tweaking the bodyshape-bound clothing code for any future efforts to port species with atypical forms.

Testing Evidence

Changelog

🆑
add: Teshari
fix: Digitigrade females now recieve proper jumpsuit sprites
/:cl:

SylvetteSylph · 2025-10-31T10:52:07Z

YEAAAAH!!!!!!

nikothedude · 2025-10-31T22:39:03Z

modular_doppler/modular_species/species_types/teshari/teshari.dm

+	/// The tablerun ability we will give to our teshari.
+	var/datum/action/innate/teshari_tablerun/tablerun
+
+/datum/language_holder/teshari


btw we will have to revisit schiechi as we develop teshari, its a 1:1 from nova

nikothedude · 2025-11-01T01:51:45Z

idk why screenshot tests are failing, i tested the clothes the moth is wearing. theyre fine

Signed-off-by: nikothedude <59709059+nikothedude@users.noreply.github.com>

00-Steven

not done reviewing this yet, started earlier but got tired/sick midway through

code/__DEFINES/~doppler_defines/teshari.dm

code/__DEFINES/~doppler_defines/_autogen_clothing_defines.dm

nikothedude · 2025-11-03T21:19:59Z

code/game/objects/structures/tables_racks.dm

 	if(is_flipped)
 		return FALSE
-	if(M.has_gravity() && M.mob_size > MOB_SIZE_SMALL && !(M.movement_type & MOVETYPES_NOT_TOUCHING_GROUND))
+	if(M.has_gravity() && M.mob_size > MOB_SIZE_SMALL && !(M.movement_type & MOVETYPES_NOT_TOUCHING_GROUND) && (!isteshari(M))) // Doppler edit addition - Teshari can tablerun without breaking glass tables


we may not want this. its funny to run on a table and for it to instantly break but its also annoying and not how it was on nova. thoughts?

I think it shouldn't be an isteshari typecheck, ideally
either a trait and done as a multi-line edit early return before this, or the funny option with potential major consequences would be to make all teshari torso owners mob size small

nikothedude · 2025-11-03T21:20:32Z

code/modules/clothing/under/accessories/_accessories.dm

+				var/potential_file = bodyshape_icon_files["[shape]"]
+				if (icon_exists(potential_file, icon_state))
+					local_worn_icon = bodyshape_icon_files["[shape]"]
+					if (shape != BODYSHAPE_HUMANOID) // EVERYTHING has this


i rly hate how i copy pasted this code around, but i thought about it and im blanking on how to procify it

nikothedude · 2025-11-03T21:22:20Z

modular_doppler/modular_customization/preferences/preference.dm

+ *
+ * If this returns TRUE, allows the species to access our customization.
+ */
+/datum/preference/proc/species_can_access_mutant_customization(species_typepath)


i heard ppl were confused why i procified this,

honestly, its probably just an artifact of my tendency to turn little distinct bits of functionality into, well, functions. this is totally not needed, especially as the implementation is only one step above straight copy and pasting the same code into each function in tails.dm, so if requested, i can revert this

nikothedude · 2025-11-03T21:22:38Z

modular_doppler/modular_customization/preferences/tail.dm


 /datum/preference/choiced/tail_variation/init_possible_values()
-	return list(NO_VARIATION) + (GLOB.mutant_variations)
+	return list(NO_VARIATION) + (GLOB.mutant_variations) + list(TESHARI)


this works perfectly now btw

nikothedude · 2025-11-03T21:23:07Z

modular_doppler/modular_species/_species.dm

+ * Determines if we're allowed to regenerate a mutant appearance/organ associated with the feature key.
+ * By default, returns FALSE if we cant have mutant organs.
+ */
+/datum/species/proc/can_regenerate_mutant_feature(feature_key)


same deal here as the other procified code

nikothedude · 2025-11-03T21:23:47Z

modular_doppler/modular_species/species_types/teshari/prosthetics/mechfabricator_designs.dm

+		RND_CATEGORY_CYBERNETICS + RND_SUBCATEGORY_CYBERNETICS_ADVANCED_RAPTORAL,
+	)
+
+/datum/design/teshari_advanced_r_arm


note there is no advanced tesh limb sprite so its the same as the default

nikothedude · 2025-11-03T21:24:32Z

A few things I forgot to mention

Only tesh can use their ears, and anyone can use tesh tails and tesh can use non-tesh tails.

nikothedude · 2025-11-04T16:32:25Z

Also, waiting on lore til it can be fullmerged

modular_doppler/modular_species/species_types/teshari/teshari_organs.dm

…organs.dm Co-authored-by: kittysmooch <105110468+kittysmooch@users.noreply.github.com> Signed-off-by: nikothedude <59709059+nikothedude@users.noreply.github.com>

github-actions · 2025-11-22T01:52:09Z

This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself

00-Steven

slowly working on this, posting these in piecemeal

code/__DEFINES/mobs.dm

00-Steven · 2025-12-14T01:58:46Z

code/game/objects/structures/tables_racks.dm

 	if(is_flipped)
 		return FALSE
-	if(M.has_gravity() && M.mob_size > MOB_SIZE_SMALL && !(M.movement_type & MOVETYPES_NOT_TOUCHING_GROUND))
+	if(M.has_gravity() && M.mob_size > MOB_SIZE_SMALL && !(M.movement_type & MOVETYPES_NOT_TOUCHING_GROUND) && (!isteshari(M))) // Doppler edit addition - Teshari can tablerun without breaking glass tables


I think it shouldn't be an isteshari typecheck, ideally
either a trait and done as a multi-line edit early return before this, or the funny option with potential major consequences would be to make all teshari torso owners mob size small

modular_doppler/modular_species/species_types/teshari/teshari_clothes.dm

code/game/objects/structures/tables_racks.dm

le push

b0243c1

github-actions bot added do not merge Config Update Config changes, Ping kannthus. Sprites Funny little pixels on our screen Feature Something new, something fresh. labels Oct 31, 2025

nikothedude added 3 commits October 31, 2025 14:40

push

04b0092

no food

27ddac0

okay. and now, we polish

56a5b3c

github-actions bot added the Fix Pest removal; Bugs label Oct 31, 2025

nikothedude added 3 commits October 31, 2025 18:09

aaa

c2d2749

cleanup, docs, some reorg

44997e0

a!

38f6161

nikothedude commented Oct 31, 2025

View reviewed changes

nikothedude changed the title ~~[BOUNTY] [DNM] Teshari~~ [BOUNTY] [TEST-MERGE ONLY] Teshari Oct 31, 2025

i totally forgot this

78e6276

github-actions bot added the Sound Soundwaves that hit the player at roughly 342 m/s label Oct 31, 2025

nikothedude marked this pull request as ready for review October 31, 2025 22:42

nikothedude requested review from 00-Steven and carpotoxin as code owners October 31, 2025 22:42

kannthus added Test Merge Only and removed do not merge labels Oct 31, 2025

nikothedude added 5 commits October 31, 2025 19:01

ci moment

874459c

lets try this

e6bd5e8

glorp

5b5b610

aaaaaaaaaaaaaaagh

f25e2fa

remove double defs (is he stupid?)

9204370

nikothedude and others added 2 commits October 31, 2025 23:36

Merge branch 'master' into teshari

c2da6a6

Signed-off-by: nikothedude <59709059+nikothedude@users.noreply.github.com>

fix cmo labcoat sprite

af918ff

nikothedude added 2 commits November 1, 2025 22:16

markings, cybernetics

37abdf9

lmfao

04d96bc

00-Steven reviewed Nov 2, 2025

View reviewed changes

code/__DEFINES/~doppler_defines/teshari.dm Show resolved Hide resolved

code/__DEFINES/~doppler_defines/_autogen_clothing_defines.dm Show resolved Hide resolved

forgot to remove dev comments, bneither of these are relevant anymore

f1089ed

github-actions bot requested a review from 00-Steven November 2, 2025 20:06

nikothedude added 2 commits November 3, 2025 16:17

cleanup, moving, fixes...

9e39eed

remove unused def

5f587a1

nikothedude commented Nov 3, 2025

View reviewed changes

absolute dogshit

bdda8e0

kittysmooch reviewed Nov 14, 2025

View reviewed changes

modular_doppler/modular_species/species_types/teshari/teshari_organs.dm Outdated Show resolved Hide resolved

Update modular_doppler/modular_species/species_types/teshari/teshari_…

fe3c5cb

…organs.dm Co-authored-by: kittysmooch <105110468+kittysmooch@users.noreply.github.com> Signed-off-by: nikothedude <59709059+nikothedude@users.noreply.github.com>

github-actions bot added the Merge Conflict label Nov 14, 2025

github-actions bot added the Stale label Nov 22, 2025

kannthus added No Stale Overrules the github stale actions. and removed Stale labels Nov 22, 2025

00-Steven reviewed Dec 14, 2025

View reviewed changes

blacklist ovbersized/undersized, add no table break trait

e7f5aaa

github-actions bot requested a review from 00-Steven December 14, 2025 05:12

nikothedude added 2 commits December 14, 2025 21:22

refactor wintercoat undeployed stuff, clean up an unused args, docs...

c67f8ab

why was this even a spell

cac35e8

00-Steven reviewed Dec 16, 2025

View reviewed changes

code/game/objects/structures/tables_racks.dm Outdated Show resolved Hide resolved

of course, madame ephe

93423c6

github-actions bot requested a review from 00-Steven December 16, 2025 23:23

nikothedude and others added 2 commits December 21, 2025 17:52

wweeee INCOMPLETE REFACTOR BUT I HAV TO COMMIT IT

14ae738

aaaaaabhhh

11d5c9a

[BOUNTY] [TEST-MERGE ONLY] Teshari #787

Are you sure you want to change the base?

[BOUNTY] [TEST-MERGE ONLY] Teshari #787

Conversation

nikothedude commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

About The Pull Request

Why It's Good For The Game

Testing Evidence

Changelog

Uh oh!

SylvetteSylph commented Oct 31, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikothedude commented Nov 1, 2025

Uh oh!

00-Steven left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikothedude commented Nov 3, 2025

Uh oh!

nikothedude commented Nov 4, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 22, 2025

Uh oh!

00-Steven left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nikothedude commented Oct 31, 2025 •

edited

Loading