Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump node version to node20 and update dependencies #13

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

watsonian
Copy link
Contributor

This moves the action from node16 to node20 in preparation for GitHub moving all all actions to Node20. This also updates all dependencies.

Copy link
Member

@nmanoogian nmanoogian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, @watsonian!

Just confirming, did you get a chance to test this?

package.json Show resolved Hide resolved
@watsonian
Copy link
Contributor Author

Just confirming, did you get a chance to test this?

I didn't test it myself, but the tests for the action run through the installation process and verify the CLI got installed as expected. Are we able to have a workflow from a separate project that installs an unpublished action by SHA or something? I could do that if we don't think the tests are sufficient.

@patsissons
Copy link

I ran this through our CI and seemed to work great 🎉

-        uses: dopplerhq/cli-action@v2
+        uses: dopplerhq/cli-action@watsonian/bump-nodejs-version

@nmanoogian
Copy link
Member

I ran this through our CI and seemed to work great 🎉

Thanks @patsissons!

@nmanoogian nmanoogian merged commit 014df23 into master Jan 30, 2024
6 checks passed
@nmanoogian nmanoogian deleted the watsonian/bump-nodejs-version branch January 30, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants