Skip to content

hierarchical encoder decoder #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

junbeomlee
Copy link
Contributor

구현은 했는데 if문이 너무 많아져서
LSTM인경우와 bi인경우 계속 tf.stack이 다르게 작동하네요 ㅠㅠ
왜그럴까요?

특히 LSTM, GRU(RNN)인 경우에 output의 모양과 타입이 달라서 tf.stack([output])해줘야하는경우도 있고 tf.stack(output)해줘야 되는경우도 있고 그러네요 ㅠㅠ 흠..

@DongjunLee
Copy link
Owner

그러게요..! if문들이 너무 많아졌군요
저도 해당 API 문서를 조금 더 살펴봐야할 것 같네요ㅎㅎ

일단 session_level_encoder 의 경우, data_loader 도 같이 준비를 해야하는 부분이라..
해당 부분들 더 살펴보고 나서 코드 수정하고 머지할게요!
Pull request 감사드립니다 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants