Black Images

[springiemedia]

Recently, this package has started producing black images from a number of newer devices e.g. Samsung s20 ultra.

[paul-thebaud]

Hi!
Same problem on Macbook Pro 16" 2019 (MacOS BigSur) with Google Chrome 87.0.4280.66.
PNG with transparency are getting black backgrounds.

[paul-thebaud]

Locking the package version to 1.0.12 resolved the problem for me.
It seems it is due to 1.0.13 version.

[springiemedia]

Locking the package version to 1.0.12 resolved the problem for me.
It seems it is due to 1.0.13 version.

Interesting, the issue was present on 1.0.12 for me. However the black is resulting from jpegs not PNG.

[paul-thebaud]

@springiemedia black on JPEG? There is no transparency on JPEG, so what the black is replacing?
(on PNG, it replaces transparent background with black)

[ndanvers]

I am essentially working with stock images, none of these have been taken with a newer phone or device to my knowledge.

Current Package version : 1.0.13 => Transparency is replaced by a Black backgrounds on PNG
Revert to Package version : 1.0.12 => Re-upload images => Black backgrounds are no longer present.

Secondly, 1.0.13 seems to have caused an issue for PNG encoding on my end.
1.0.13 : PNG files are being encoded "incorrectly" => data:image/png;base64 is proceeded by what looks like JPG base64
1.0.12 : PNG files are being encoded "correctly" => data:image/png;base64 is proceeded by png b64 "IVBOR..."

At the moment => JPEG files are not causing me an issue.

[paul-thebaud]

Hi everyone,
I do not have the issue on MacOS with 1.0.12, but I tried with Windows and the issue is present with Chrome and Firefox.
@Donaldcwl, is a fix for this issue planned soon?

[Donaldcwl]

Thanks for raising this issue. I am looking into the problem.
It would be nice if you can also fork the repo and do some debugging together :)

[paul-thebaud]

Hi @Donaldcwl,
I searched inside the diff between 1.0.12 and 1.0.13, and tested on my side.
It seems the bug for PNG on 13 is due to this line : v1.0.12...v1.0.13#diff-323d121619a5b1b8d744f61f889b377cba0feef34cb341ba78c79966386212b7R100
When I change the tempFileType to outputFileType (inside canvasToFile call), it seams the bug is fixed.
I tested on MacOS, so the problem might not be fixed on Windows.

[xmd5a]

@Donaldcwl do you still need help with this issue?

[Donaldcwl]

Hi all, the issue has been fixed in v1.0.14.

[paul-thebaud]

@Donaldcwl Hi, seems working on MacOS BS+Chrome and Windows10+Chrome, thanks!

[xmd5a]

1.0.14 do not fix this at all.
Still I have this error on iPhone 7 + iOS 14 + chrome or/and safari browser using jpeg photos (if you need sample photo I can send it to you because not every jpeg is invalid converted)

[Donaldcwl]

@xmd5a This black image issue we fix here is related to transparent PNG image only, isn't it?
What issue do you encounter on your iPhone with JPEG image?
Please send me the images either upload them here in github or email me.

[paul-thebaud]

Locking the package version to 1.0.12 resolved the problem for me.
It seems it is due to 1.0.13 version.

Interesting, the issue was present on 1.0.12 for me. However the black is resulting from jpegs not PNG.

@Donaldcwl see this. Issues appears on JPEG too (I didn't faced this case).