Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic support for unknown record types like CAA #98

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

pawel-kow
Copy link
Member

This PR adds a generic support for unknown record types, like CAA or others.
Also JSON schema and template example has beed added for reference.

Signed-off-by: Sami Kerola <kerolasa@iki.fi>
Copy link
Collaborator

@kerolasa kerolasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just couple review comments to consider. After that feel free to merge.

example_template.json Outdated Show resolved Hide resolved
Domain Connect Spec Draft.adoc Outdated Show resolved Hide resolved
Domain Connect Spec Draft.adoc Outdated Show resolved Hide resolved
@jkolker-godaddy
Copy link

I have reviewed changes with dev and they have approved.

Copy link

@wdbaker-godaddy wdbaker-godaddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on JK comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants