-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic support for unknown record types like CAA #98
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Sami Kerola <kerolasa@iki.fi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. Just couple review comments to consider. After that feel free to merge.
I have reviewed changes with dev and they have approved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on JK comment
This PR adds a generic support for unknown record types, like CAA or others.
Also JSON schema and template example has beed added for reference.