-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor cleanups #92
Minor cleanups #92
Conversation
The TTL field as a variable is not currently supported. The "launchURL" is removed because it does not appear anywhere else in the spec. Signed-off-by: Sami Kerola <kerolasa@iki.fi>
After this there are still some references to public domains and IPs where they cannot be easily changed. RFC 2606: Reserved Top Level DNS Names RFC 5737: IPv4 Address Blocks Reserved for Documentation Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This fixes nine warnings similar to the one mentioned below. $ asciidoctor "./Domain Connect Spec Draft.adoc" asciidoctor: WARNING: Domain Connect Spec Draft.adoc: line 2204: section title out of sequence: expected level 2, got level 3 [...] Signed-off-by: Sami Kerola <kerolasa@iki.fi>
This is good stuff. TBH I was not aware of RFC 2606 and RFC 5737 so it's useful in context of potential IETF submission. What are the other places and why it's not easy to fix them? Very interesting catch with the examples of variables in TTL field. It may increase the chance that this "feature" is actually implemented by some folks if they based more on examples rather than normative text. Let's discuss it in the next call. |
For example These are not impossible to fix, but a bit more involved than just sed 's/this/that/' |
Got it. For the screenshots I'm afraid I don't even have the source files for them, so one would need to create new ones or take a different approach. For the signature the keys seem to be the same as in example service, so the private key is also in the source code (sic!): https://exampleservice.domainconnect.org/sig tool "Generating the Signature" can create a new signature and without private key it will even use the one of example service, so the task should not be that difficult. |
This pull request contains three commits.
fix example template
The TTL field as a variable is not currently supported. The "launchURL"
is removed because it does not appear anywhere else in the spec.
Signed-off-by: Sami Kerola kerolasa@iki.fi
try to use documentation IPs and domains when possible
After this there are still some references to public domains and IPs where
they cannot be easily changed.
RFC 2606: Reserved Top Level DNS Names
RFC 5737: IPv4 Address Blocks Reserved for Documentation
Signed-off-by: Sami Kerola kerolasa@iki.fi
use asciidoc title levels in sequence
This fixes nine warnings similar to the one mentioned below.
Signed-off-by: Sami Kerola kerolasa@iki.fi