Update getreadydigital.com.cname-record.json #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawel-kow
added a commit
to Domain-Connect/spec
that referenced
this pull request
Sep 14, 2023
|
Template is OK. With |
|
This change looks good to me. And the linter got fix about host check, see the change below. |
pawel-kow
requested changes
Sep 18, 2023
There was a problem hiding this comment.
@mike-kirby-dev do you still consider this template change necessary, after the issue with the linter has been corrected?
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days. |
|
Closing stale PR after 15 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following review of the Template Record section of the spec, this change reflects a fix based on the Description for Type CNAME to change the host to a variable from '@' - "CNAME: host, pointsTo, TTL (host must not be null or @)" (https://github.com/Domain-Connect/spec/blob/master/Domain%20Connect%20Spec%20Draft.adoc#53-template-record). This is also highlighted as an error in the template linter tool for our template.