Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jersey Watch as a Service Provider #251

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

nratter
Copy link
Contributor

@nratter nratter commented Jul 2, 2022

Thanks in advance for the review and let me know if anything needs to change :)

Copy link
Member

@pawel-kow pawel-kow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pawel-kow
Copy link
Member

@bdickson1-godaddy can you take a look pls? For me it's OK but I recall GD pushing back on templates without signing, not sure if it's a firm policy though.

@nratter
Copy link
Contributor Author

nratter commented Jul 11, 2022

Hey guys... just following up here! Would you recommend I modify the template to include signing?

@pawel-kow
Copy link
Member

Ok, no feedback from GD so I merge this one as well for now.

@pawel-kow pawel-kow merged commit 4a1d73e into Domain-Connect:master Jul 22, 2022
@bdickson1-godaddy
Copy link
Contributor

bdickson1-godaddy commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants