New: works with variants #9729
Merged
New: works with variants #9729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
simnandez
commented
Oct 11, 2018
•
simnandez
commented
- If product is parent showing stock of childs and not itself
- Add function hasVariants for knowing if product has variants
added 4 commits
October 11, 2018 12:08
- If product is parent showing stock of childs and not itself - Add function hasVariants for know if product has variants
- Hide child products into list if PRODUIT_ATTRIBUTES_HIDECHILD is activated
- Make the checkbox working correctly
eldy
reviewed
Oct 12, 2018
htdocs/product/list.php
Outdated
| $moreforfilter.='<div class="divsearchfield">'; | ||
| $moreforfilter.= '<input type="checkbox" id="search_hidechildproducts" name="search_hidechildproducts" value="on"'.($search_hidechildproducts ? 'checked="checked"' : '').'>'; | ||
| $moreforfilter.= ' <label for="search_hidechildproducts">'.$langs->trans('HideChildProducts').'</label>'; | ||
| $moreforfilter.= '<input type="checkbox" id="show_childproducts" name="show_childproducts"'.($show_childproducts ? 'checked="checked"':'').'>'; |
There was a problem hiding this comment.
the name of fields used into the search criteria must always start with "search_" (if not, it breaks the feature to save criteria when leaving a page and going back on it). Can you rename it into search_showchildproducts ?
eldy
added
the
PR to fix - See feedback in comments
simnandez
removed
the
PR to fix - See feedback in comments
|
@eldy I fixed it! |
added 2 commits
October 15, 2018 12:45
# Conflicts: # htdocs/product/class/product.class.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.