FIX: when qty is not an integer, apply price() #31138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecision errors if php.ini's precision settings are too high
eldy
reviewed
Sep 26, 2024
htdocs/compta/stats/cabyprodserv.php
Outdated
| @@ -425,7 +425,7 @@ | |||
|
|
|||
| // Quantity | |||
| print '<td class="right">'; | |||
| print $qty[$key]; | |||
| print $qty[$key] == round($qty[$key]) ? $qty[$key] : price($qty[$key]); | |||
There was a problem hiding this comment.
Why not doing
price($qty[$key], 1, $langs, 0, 0);
all the time ?
There was a problem hiding this comment.
Thanks, this is way better indeed.
eldy
added
the
Discussion
atm-florianm
commented
Sep 26, 2024
atm-florianm
deleted the
FIX_125_DA025540_cabyprodserv_display_floating_point_qty_nicely
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: weird qty shown
Issue
Currently, the report
cabyprodserv.phpdisplays the quantity column as is:Some companies use non-integer quantities.
Due to the non-infinite precision of binary representation and arithmetic, floats can sometimes be counter-intuitive.
One of our customers has this problem (weird quantities such as 7.600000000000001 appear on screen). Using
price()when the number has non-zero decimals seems to work and enables the customer to better control how the decimals are displayed.