fix: support macOS installation and add swarm init guidance#140
Open
cheonkyu wants to merge 2 commits intoDokploy:mainfrom
Open
fix: support macOS installation and add swarm init guidance#140cheonkyu wants to merge 2 commits intoDokploy:mainfrom
cheonkyu wants to merge 2 commits intoDokploy:mainfrom
Conversation
|
|
||
| # check if is running inside a container | ||
| if [ -f /.dockerenv ]; then | ||
| echo "This script must be run on Linux" >&2 |
There was a problem hiding this comment.
error message says "must be run on Linux" but script now supports macOS - update message to say "cannot be run inside a container" or similar
Additional Comments (1)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces support for macOS (Docker Desktop) to the installation script. Currently, the script is restricted to Linux, but many developers use macOS for testing and local development.
Key Improvements:
Related Issue: dokploy/dokploy#2409
Greptile Summary
This PR adds macOS support to the Dokploy installation script by introducing OS detection, replacing Linux-specific commands with portable alternatives, and adding helpful guidance for Docker Swarm initialization issues.
Key changes:
IS_MACdetection to identify macOS environmentssscommand with portablecheck_port()helper that useslsofon macOSIssues found:
osascriptcommand for getting the private IP uses invalid AppleScript syntax and will always fail, falling back to127.0.0.1Confidence Score: 3/5
127.0.0.1on macOS instead of detecting the actual private IP, which defeats part of the purpose of the PR. The other issues are minor (misleading error messages, unnecessary root check).get_private_ip()function at line 193 requires immediate attention to fix the broken osascript commandLast reviewed commit: d98717a
(2/5) Greptile learns from your feedback when you react with thumbs up/down!