Update to 1.21.5 #135
Draft
Update to 1.21.5 #135
+5,293
−2,001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LukynkaCZE
commented
Mar 26, 2025
•
LukynkaCZE
commented
- Update registries
- Add new entity variant data generators
- Add dockyard registries for new entity variants
- Add NBT writer for new entity variants
- Make abstract data generator for entity variants
- Update protocol
- Look at NBT changes
- Add Saddle equipment slot
- Update Entity Metadata thingies
- Add minecraft:custom_data to entities
- Update item components
- Update particles and particle data
- Update scroll text component format
|
State is joinable |
…into update/1.21.5
p1k0chu
suggested changes
Apr 5, 2025
p1k0chu
approved these changes
Apr 5, 2025
p1k0chu
reviewed
Apr 6, 2025
Comment on lines
+20
to
+31
| fun <T> KClass<*>.read(buffer: ByteBuf): T { | ||
| val companion = this.companionObject ?: throw IllegalStateException("Class $simpleName does not have companion object") | ||
| val readFunction = companionObject!!.declaredMemberFunctions.find { member -> member.name == "read" } ?: throw IllegalStateException("Class $simpleName does not have a read function") | ||
| try { | ||
| @Suppress("UNCHECKED_CAST") | ||
| return readFunction.call(companion.objectInstance as (NetworkReadable<T>), buffer) as T | ||
| } catch (exception: Exception) { | ||
| log("Failed to call read on class ${this.simpleName}") | ||
| log(exception) | ||
| throw IllegalStateException("Calling the read method failed: $exception") | ||
| } | ||
| } |
There was a problem hiding this comment.
not sure, but it is there for stuff that is not NetworkReadable yet ig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.