Test/events

[p1k0chu]

slowly adding tests for events

[LukynkaCZE]

holy shit you are the goat

[p1k0chu]

:D
do you think the player should work for entity damage event because i noticed it doesn't work

[LukynkaCZE]

:D do you think the player should work for entity damage event because i noticed it doesn't work

probably yes

[p1k0chu]

i love how some tests in entity view system just fail to rng

for some reason there's some other entity left-over before the EntityViewSystem tests started but idk where it comes from
and then assertion 1 == count_entities_player_can_see fails

[LukynkaCZE]

Yeah I know I couldn't find it either

[p1k0chu]

should i rebase this hell of merge commits onto master before undrafting?

[LukynkaCZE]

Yeah sure, also if it wouldn't be much maybe have something to make sure every event has test? Just to force me to add tests for when I add new events cause I will 100% forget. Maybe just get all event classes via reflection and have a map in event tests where you map the event class to the test class. Then loop over all the event classes and if it doesn't have a test class associated with it fail the test

That was I'm actually forced to add them for new events cause for publish tests have to pass first

[LukynkaCZE]

Also just wanna say I very much appreciate you taking time to do this and generally contribute! :3

[p1k0chu]

That was I'm actually forced to add them for new events cause for publish tests have to pass first

Well right now some events do not have tests so that would just fail every time for a while 😭

[LukynkaCZE]

That was I'm actually forced to add them for new events cause for publish tests have to pass first

Well right now some events do not have tests so that would just fail every time for a while 😭

thats fine I think

[p1k0chu]

did i cook

[p1k0chu]

also rip github action its not gonna like this one

[LukynkaCZE]

did i cook

Oh you did 🔥

Also I gotta figure out why it says insufficient permissions to upload the results in prs not done by me

[p1k0chu]

incredible
_{works on my machine}

[p1k0chu]

i wont make tests for those events left
(they are packets :c)

[LukynkaCZE]

Alright I will see if I can add tests for all the packet events later in some magic way, thanks for the contribution again <3