Set positionalParams as a static property on the class.
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The beta and canary builds failed due to needing an updated version of ember-qunit, I submitted a separate PR fixing those failures (#54) I'll rebase this once those fixes are in so we can see Travis 📗. |
Ember 1.13.6 will be deprecating usage of `positionalParams` set within `.extend` in favor of it being set as a static property on the class itself (`.reopenClass`). This makes both 1.13.0 - 1.13.5 and 1.13.6+ work without deprecation.
rwjblue
force-pushed
the
set-positionalParams-on-class
branch
from
d9cb65f
to
60b5943
Compare
|
Cool, looks like #54 fixed the build. This is green now. |
bcardarella
added a commit
that referenced
this pull request
Jul 31, 2015
Set `positionalParams` as a static property on the class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 1.13.6 will be deprecating usage of
positionalParamsset within.extendin favor of it being set as a static property on the class itself (.reopenClass).This makes both 1.13.0 - 1.13.5 and 1.13.6+ work without deprecation.
See the following issues/PR's for details: