Conversation
Fixed:Posts being hidden on profile page when "hide read post" is enabled
|
Since now users can set custom quality for autoplaying videos it best to let them choose if they want auto play or not with data saving |
| <ml.docilealligator.infinityforreddit.customviews.preference.CustomFontPreference | ||
| app:title="API Keys" | ||
| app:icon="@drawable/ic_security_day_night_24dp" | ||
| app:fragment="ml.docilealligator.infinityforreddit.settings.ApiKeysPreferenceFragment" /> | ||
|
|
There was a problem hiding this comment.
I can't add custom API key support to Infinity.
| <string name="settings_data_saving_mode_info_summary">In data saving mode: | ||
| Preview images are in lower resolution. | ||
| Reddit videos are in lower resolution. | ||
| Video autoplay is disabled.</string> |
There was a problem hiding this comment.
Why is \n getting removed here?
There was a problem hiding this comment.
I think this is for custom API key support, right? Infinity can't have that.
There was a problem hiding this comment.
Yeah sorry that is correct you can remove that
| boolean overrideVideoAutoplay = sharedPreferences.getBoolean(SharedPreferencesUtils.OVERRIDE_VIDEO_AUTOPLAY_IN_DATA_SAVING_MODE, false); | ||
| if (overrideVideoAutoplay) { | ||
| mAutoplay = true; | ||
| } else if (autoplayString.equals(SharedPreferencesUtils.VIDEO_AUTOPLAY_VALUE_ALWAYS_ON)) { |
There was a problem hiding this comment.
Even if you override the autoplay setting in data saving mode, you still need to check if it's in wifi or data.
There was a problem hiding this comment.
Why ? If we override that , i.e videos should always autoplay regardless of it being on data or wifi ? I have build and tested it and it works just fine
There was a problem hiding this comment.
Because if the users don't care about data usage, then they won't enable data saving mode in the first place. And what's the point of force enabling it in data saving while the setting is turned off in settings->videos?
There was a problem hiding this comment.
Because if the users don't care about data usage, then they won't enable data saving mode in the first place. And what's the point of force enabling it in data saving while the setting is turned off in settings->videos?
For users who want more granular control over data usage , can have this meaning they want to minimise data usage without sacrificing convince of autoplay so it's optional. Also for settings->autoplay one that only enables auto if data saving is disabled. Again it's just a option that user can use if so they wish let me know if want anything changed other than api which I will soon change and create a new PR
|
@Docile-Alligator any update? |
2 participants
Added:Button to force autoplay on data-saving
Fixed:Posts being hidden on profile page when "hide read post" is enabled