refactor: Simplify UpdateApplication mechanism, get rid of the SKIP func #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykwozinski
changed the title
patrykwozinski
commented
Jan 18, 2022
Comment on lines
-102
to
-104
| //TODO: Review how to do when skip | ||
| } else if skip { | ||
| return nil, nil |
There was a problem hiding this comment.
That was the goal of these changes.
danielkorytek
approved these changes
Jan 18, 2022
MatteoManzoni
approved these changes
Jan 18, 2022
xoanmm
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, this small refactor is about getting rid of returning 3 params including the
skipboolean value.I have realized that if we're returning an empty list of ChangeEntry - that means there are no changes, and it's equivalent of the
skipfunctionality.