chore: Use const with values instead of hardcoded strings #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrykwozinski
changed the title
patrykwozinski
force-pushed
the
use-const-instead-of-hardcoded-flag-names
branch
from
ce23a25 to
72ba995
Compare
xoanmm
reviewed
Jan 13, 2022
xoanmm
approved these changes
Jan 13, 2022
MatteoManzoni
approved these changes
Jan 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, it's a good practice to keep hardcoded strings (which occur multiple times) separated as const values. Thanks to that we could avoid mistakes with typos, etc. Also, on the. top of the command we'll see all possible flags. WinWin!