feat: improve CI and configure pre-commit #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xoanmm
changed the title
MatteoManzoni
approved these changes
Jan 31, 2022
xoanmm
requested review from
a team,
lupiuz,
rafalbochenski and
danielkorytek
and removed request for
a team
danielkorytek
approved these changes
Feb 10, 2022
patrykwozinski
approved these changes
Feb 10, 2022
Comment on lines
+1
to
+32
| default_stages: [commit, push] | ||
| minimum_pre_commit_version: "1.20.0" | ||
| repos: | ||
| - repo: https://github.com/dnephin/pre-commit-golang | ||
| rev: v0.3.5 | ||
| hooks: | ||
| - id: go-fmt | ||
| name: Run go fmt against the code | ||
| - repo: https://github.com/pre-commit/pre-commit-hooks | ||
| rev: v3.4.0 | ||
| hooks: | ||
| - id: trailing-whitespace | ||
| - id: end-of-file-fixer | ||
| - id: check-merge-conflict | ||
| - id: mixed-line-ending | ||
| - repo: https://github.com/thlorenz/doctoc.git | ||
| rev: v2.0.0 | ||
| hooks: | ||
| - id: doctoc | ||
| name: Add TOC for md files | ||
| files: ^README\.md$|^CONTRIBUTING\.md$ | ||
| args: | ||
| - "--maxlevel" | ||
| - "3" | ||
| - repo: local | ||
| hooks: | ||
| - id: golangci-lint | ||
| language: golang | ||
| name: Run golangci against the code | ||
| entry: golangci-lint run | ||
| types: [go] | ||
| pass_filenames: false |
xoanmm
changed the title
xoanmm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's configured pre-commit to improve the development and also avoid commit and push code with errors.
In this PR is also improve the CI introducing the static checks through the mentioned pre-commit once is correctly configured through the file
.pre-commit-config.yamlwhere the hooks are defined.