feat: Configure devcontainer #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoManzoni
approved these changes
Jan 26, 2022
JorTurFer
approved these changes
Jan 26, 2022
.devcontainer/devcontainer.json
Outdated
| "--cap-add=SYS_PTRACE", "--security-opt", "seccomp=unconfined", | ||
|
|
||
| // Use same network as created for docker-compose that create git-server container | ||
| "--network=test-git-server_default" |
There was a problem hiding this comment.
Strange name for VSC network xD
There was a problem hiding this comment.
Totally agree, I'll update in the next commit. Thanks mate 😄
.devcontainer/devcontainer.json
Outdated
|
|
||
| // Add the IDs of extensions you want installed when the container is created in the array below. | ||
| "extensions": [ | ||
| "golang.go" |
There was a problem hiding this comment.
You are installing docker, maybe you should add here docker extension. WDYT?
There was a problem hiding this comment.
I think is a good idea, added in the next commit 😄
…iner created by devcontainer
xoanmm
changed the title
xoanmm
changed the title
xoanmm
changed the title
xoanmm
changed the title
alv91
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.devcontainer