Skip to content

fix: replace deprecated PushedDate by AuthoredDate, add Author to the result #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

maksimnarkevichdp
Copy link
Contributor

image
image

@maksimnarkevichdp maksimnarkevichdp self-assigned this Sep 5, 2024
@maksimnarkevichdp maksimnarkevichdp merged commit 3ec5aed into master Sep 5, 2024
2 checks passed
@maksimnarkevichdp maksimnarkevichdp deleted the fix/pushed-date-deprecated branch September 5, 2024 09:50
@maksimnarkevichdp
Copy link
Contributor Author

@alv91 could you please create a tag for the commit merged into master? Unfortunately I don't have permissions to do that

@Yalpa
Copy link

Yalpa commented Oct 4, 2024

It was removed but in our eyes it was 0001-01-01 so any conditions in apps that are using actions and using pushedDate stopped working. Of course it was giving false positives but with removal all of the conditions were automatically false

@maksimnarkevichdp
Copy link
Contributor Author

It was removed but in our eyes it was 0001-01-01 so any conditions in apps that are using actions and using pushedDate stopped working. Of course it was giving false positives but with removal all of the conditions were automatically false

Hey @Yalpa, I am sorry if it brought you some problems, it was my first PR in that repo and I didn't know it could impact your team much. Thank you for understanding 🙏

@Yalpa
Copy link

Yalpa commented Oct 4, 2024

@maksimnarkevichdp no hard feelings. I just posted here so this could be lesson learnt for the future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants