Set DEBUG=False for GitHub Actions (Fixes #327) #355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure the build job to run with DEBUG=False instead of the default DEBUG=True. This ensures all Django management commands (check, makemigrations, collectstatic) run in production mode during CI. Also sets SECRET_KEY which is required when DEBUG=False. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Contributor
Author
|
Written by Claude, but reviewed by me, including test results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
DEBUG=Falseinstead of defaulting toDEBUG=TrueSECRET_KEYenvironment variable (required when DEBUG is False)Problem
Issue #327 reported that GitHub Actions were running with
DEBUG=True. While pytest was correctly usingtest_settings.py(which sets DEBUG=False), other Django management commands (check,makemigrations,collectstatic) were using the default settings and running with DEBUG=True.Solution
Added environment variables to the
buildjob in the GitHub Actions workflow:DEBUG: "False"- Forces all commands to run in production modeSECRET_KEY: "github-actions-secret-key"- Required by Django when DEBUG is FalseTest plan
🤖 Generated with Claude Code