Skip to content

Commit

Permalink
chore: drop activateLogicalVolumes sequencer step
Browse files Browse the repository at this point in the history
Drop `activateLogicalVolumes` sequencer step.

LVM package already ships proper udev rules to handle this.

```text
❯ tree lvm2/usr/lib/udev/rules.d/
lvm2/usr/lib/udev/rules.d/
├── 10-dm.rules
├── 11-dm-lvm.rules
├── 13-dm-disk.rules
├── 69-dm-lvm.rules
└── 95-dm-notify.rules

1 directory, 5 files
```

Fixes: siderolabs#9300

Signed-off-by: Noel Georgi <git@frezbo.dev>
  • Loading branch information
frezbo committed Sep 11, 2024
1 parent a294b36 commit e17fafa
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 15 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -271,10 +271,6 @@ func (*Sequencer) Boot(r runtime.Runtime) []runtime.Phase {
).Append(
"userSetup",
pauseOnFailure(WriteUserFiles, constants.FailurePauseTimeout),
).AppendWhen(
r.State().Platform().Mode() != runtime.ModeContainer,
"lvm",
ActivateLogicalVolumes,
).Append(
"extendPCRStartAll",
ExtendPCRStartAll,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2011,17 +2011,6 @@ func Install(runtime.Sequence, any) (runtime.TaskExecutionFunc, string) {
}, "install"
}

// ActivateLogicalVolumes represents the task for activating logical volumes.
func ActivateLogicalVolumes(runtime.Sequence, any) (runtime.TaskExecutionFunc, string) {
return func(ctx context.Context, logger *log.Logger, r runtime.Runtime) (err error) {
if _, err = cmd.Run("/sbin/lvm", "vgchange", "-ay"); err != nil {
return fmt.Errorf("failed to activate logical volumes: %w", err)
}

return nil
}, "activateLogicalVolumes"
}

// KexecPrepare loads next boot kernel via kexec_file_load.
//
//nolint:gocyclo
Expand Down

0 comments on commit e17fafa

Please sign in to comment.