Refactor/replace protokit #7
Conversation
|
Hi @coperius , sorry for a huge delay with answer I've changed the upstream a bit to make the code more testable and protokit more replaceable would you be able to rebase your PR with the lates upstream? thank you! |
1 similar comment
|
Hi @coperius , sorry for a huge delay with answer I've changed the upstream a bit to make the code more testable and protokit more replaceable would you be able to rebase your PR with the lates upstream? thank you! |
|
It's OK. But maybe you forgot to delete the test data record in the function? |
|
fixed, thank you |
Replace protokit based on the deprecated "github.com/golang/protobuf" package with a custom plugin wrapper that uses vanilla "google.golang.org/protobuf" package - Replace protokit to google protobuf in generator - Add tests for generator - Replace protokit to google protobuf in kit - Add tests for kit - Fix TemplateValue receiver name - Fix README.md - Fix go.mod/go.sum - Fix linter settings
coperius
force-pushed
the
refactor/replace-protokit
branch
from
691ebdf
to
4541501
Compare
|
Done |
|
I see too much unrelated refactoring. It's ok in general, but make reviewing way harder would you be able to stick to the current code layout for the protokit replacement task? or even provide a refactoring PR first thank you |
Replace github.com/pseudomuto/protokit based on the deprecated github.com/golang/protobuf package with a custom plugin wrapper that uses the actual google.golang.org/protobuf package