-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move away from Cloud9 and change the instruction for Chromebook #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in order to make it work with GitHub Codespace. It also doesn't break anything for local environment.
Hey @das-g , do you have some suggestions for the PR? Should I add something else? |
das-g
requested changes
Sep 27, 2024
Hey @das-g , Thank you very much for the comments! I'll answer to them one by one and then I'll send the updated PR. |
- Reverted the note for Chromebook setup. - Renamed all screenshots and text regarding the first repository creation to "my-first-repo". - Updated the "Deploy" chapter with more screenshots. - Fixed the "Create GitHub account" instructions for Chromebook setup. - Used a numbered list for Chromebook instructions. - Corrected indentation in the Chromebook markdown.
added the separate section "First Git commands".
das-g
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the issue: #1081
Changes in this pull request:
localhost
toALLOWED_HOSTS
together with '127.0.0.1', '.pythonanywhere.com'.