Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial tweaks + how to print a given element of a dictionary #102

Merged
merged 2 commits into from
Aug 8, 2014

Conversation

MarysiaLowas
Copy link
Contributor

Just a bunch of editorial tweaks really. I've also added an example how to print a given element of a dictionary.

@@ -4,7 +4,7 @@ We have different pieces in place: the `Post` model is defined in `models.py`, w

This is exactly what *views* are supposed to do: connect models and templates. In our `post_list` *view* we will need to take models we want to display and pass them to the template. So basically in a *view* we decide what (model) will be displayed in a template.

Ok, so how we will achieve it?
OK, so how we will achieve it?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "how will we achieve it" here. You mind fixing that too?

@bmispelon
Copy link
Contributor

This is some seriously awesome feedback, thanks for taking the time to fix this.

I've left a few minor comments. If you can fix those, I'll be happy to press the big shiny green "merge" button :)

Thanks again!

@bmispelon
Copy link
Contributor

To include the fix as part of the pull request, just make the changes on your computer then make a commit and push it back to github.

This should automatically update the pull request and even hide my comments (github is smart enough to detect that my comments are outdated).

bmispelon added a commit that referenced this pull request Aug 8, 2014
Editorial tweaks + how to print a given element of a dictionary
@bmispelon bmispelon merged commit 1266c23 into DjangoGirls:master Aug 8, 2014
@bmispelon
Copy link
Contributor

Dziękuję bardzo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants