Skip to content

Conversation

bramalho
Copy link
Contributor

@bramalho bramalho commented Apr 29, 2019

Q A
Branch? master
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

PSR rules should ignore missing concatenation when there's a new line after.

Changes

Added

  • rule ignoreNewlines to psr2

Example

 127 | ERROR | [x] Concat operator must be surrounded by a single space
     |       |     (Squiz.Strings.ConcatenationSpacing.PaddingFound)

even though there was a space in the concatenation.

Tests

After adding the rule, the was no more errors. Removed some spaces from the concatenations to check the errors - there was the error.

@bramalho bramalho requested review from kubaplas and mgomse April 29, 2019 12:21
@bramalho bramalho self-assigned this Apr 29, 2019
@mgomse mgomse merged commit bcce06a into master Apr 30, 2019
@bramalho bramalho deleted the feature/ignore-new-lines-concatenation-spacing branch April 30, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants