feat(disploy): buttons #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristancamejo
added
enhancement
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
20 tasks
Member
Author
|
I will change the base branch to https://github.com/Disploy/disploy/tree/feat/message-components when it gets rebased, or should we merge straight to main? Keep in mind structures like action rows exist in that branch so the end-user doesn't have to use JSON through |
tristancamejo
requested review from
GodderE2D
and removed request for
GodderE2D and
suneettipirneni
GodderE2D
requested changes
Nov 23, 2022
Member
GodderE2D
left a comment
GodderE2D
left a comment
There was a problem hiding this comment.
Code changes outside of documentation and README files have not been reviewed. Please ask another person to review these changes.
Co-authored-by: GodderE2D <55918888+GodderE2D@users.noreply.github.com>
Co-authored-by: GodderE2D <55918888+GodderE2D@users.noreply.github.com>
Co-authored-by: GodderE2D <55918888+GodderE2D@users.noreply.github.com>
Co-authored-by: GodderE2D <55918888+GodderE2D@users.noreply.github.com>
Co-authored-by: GodderE2D <55918888+GodderE2D@users.noreply.github.com>
tristancamejo
commented
Nov 23, 2022
GodderE2D
approved these changes
Nov 23, 2022
Member
GodderE2D
left a comment
GodderE2D
left a comment
There was a problem hiding this comment.
Non-documentation has not been reviewed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements buttons into Disploy!
They function in the same way as commands, with the route system. I'm thinking of adding some sort of wildcard parsing instead of exact string matches for the
custom_idmatch process so that you can do something likedelete-:idand then get theidfrom the ButtonInteraction structure, something likeButtonInteraction#params#getString("id").