Skip to content

feat(structs): Modal #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tristancamejo merged 51 commits into from
Nov 15, 2022
Merged

feat(structs): Modal #53

tristancamejo merged 51 commits into from
Nov 15, 2022

Conversation

@TenDRILLL
Copy link
Contributor

@TenDRILLL TenDRILLL commented Nov 10, 2022 •
edited
Loading

This pull request adds support for Modals.

Additions:

  • ActionRow
  • ActionRowComponent
  • Modal
  • ModalActionRowComponent
  • ModalSubmitComponent
  • ModalSubmitInteraction
  • TextInputComponent

Edits:

  • Add showModal() to CommandInteraction

@vercel
Copy link

vercel bot commented Nov 10, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
disploy-docs ✅ Ready (Inspect) Visit Preview Nov 14, 2022 at 7:49PM (UTC)

@tristancamejo tristancamejo added packages:disploy structures Keeping our structures inline with the Discord API labels Nov 10, 2022
@tristancamejo tristancamejo added this to the v1.0.0 milestone Nov 10, 2022
@TenDRILLL
Copy link
Contributor Author

TenDRILLL commented Nov 10, 2022

This PR is missing ModalSubmitInteraction, I request to hold the Merge until it's been added,
for this PR to provide full functionality with Modals. Review of previous commits can be done prior to the addition.

@tristancamejo
Copy link
Member

tristancamejo commented Nov 10, 2022

This PR is missing ModalSubmitInteraction, I request to hold the Merge until it's been added,
for this PR to provide full functionality with Modals. Review of previous commits can be done prior to the addition.

I’ll convert it to a draft for you

@tristancamejo tristancamejo marked this pull request as draft November 10, 2022 04:03
@TenDRILLL
Copy link
Contributor Author

TenDRILLL commented Nov 10, 2022

Issues:
src/structs/ActionRow.ts(7,13): error TS6133: 'type' is declared but its value is never read.

src/structs/ModalSubmitInteraction.ts(11,29): error TS2339: Property 'custom_id' does not exist on type 'APIModalSubmitInteraction'.
src/structs/ModalSubmitInteraction.ts(12,31): error TS2339: Property 'components' does not exist on type 'APIModalSubmitInteraction'.

What should I use instead of APIModalSubmitInteraction?

@TenDRILLL TenDRILLL marked this pull request as ready for review November 10, 2022 21:28
suneettipirneni
suneettipirneni suggested changes Nov 10, 2022
View reviewed changes
TenDRILLL and others added 2 commits November 11, 2022 00:14
@TenDRILLL
refactor(structs): Array<T> -> T[]
ff7f086
@TenDRILLL @suneettipirneni
refactor(structs): Modal pseudo-optional properties
10ea2ba 
Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
@TenDRILLL
Merge remote-tracking branch 'origin/main'
8ec53c9 
# Conflicts:
#	packages/disploy/src/structs/Modal.ts
@TenDRILLL
Copy link
Contributor Author

TenDRILLL commented Nov 11, 2022

Issues: src/structs/ActionRow.ts(7,13): error TS6133: 'type' is declared but its value is never read.

src/structs/ModalSubmitInteraction.ts(11,29): error TS2339: Property 'custom_id' does not exist on type 'APIModalSubmitInteraction'. src/structs/ModalSubmitInteraction.ts(12,31): error TS2339: Property 'components' does not exist on type 'APIModalSubmitInteraction'.

What should I use instead of APIModalSubmitInteraction?

This still requires assistance.

@TenDRILLL
Copy link
Contributor Author

TenDRILLL commented Nov 14, 2022

Also require help with implementing the ModalSubmitInteraction to Router.

@tristancamejo tristancamejo changed the base branch from main to feat/message-components November 14, 2022 08:06
tristancamejo
tristancamejo requested changes Nov 14, 2022
View reviewed changes
Copy link
Member

@tristancamejo tristancamejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address requested changes and pass CI.

@tristancamejo
Copy link
Member

tristancamejo commented Nov 14, 2022

I’ll be merging this to another branch for other people to finish implementing message components (handling modals, buttons, etc) then I’ll be merging to main.

That’s after you address the requested changes though.

Thanks ❤️

@TenDRILLL
Copy link
Contributor Author

TenDRILLL commented Nov 14, 2022

Changes requested added, and CI passes.

@tristancamejo tristancamejo merged commit 72e1e12 into Disploy:feat/message-components Nov 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tristancamejo tristancamejo tristancamejo requested changes

@suneettipirneni suneettipirneni Awaiting requested review from suneettipirneni

Assignees

No one assigned

Labels

packages:disploy structures Keeping our structures inline with the Discord API

Projects

None yet

Milestone

v1.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TenDRILLL @tristancamejo @suneettipirneni