Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use the native libcst parser #969

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Mar 1, 2023

Summary

Use the native libcst parser. Its not yet compatiable with all 3.10 and 3.11 features (eg match statements and the new union format), but that's okay, as we're compatible with python 3.8 and so we don't use those features.

This should result in codemods being faster both locally and in ci.

Depending on when #958 is merged, a change will need to be made to add this environment to both codemods.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added s: needs review Issue/PR is awaiting reviews t: meta Changes to the project itself (CI, configs, etc.) labels Mar 1, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Mar 1, 2023
@onerandomusername onerandomusername force-pushed the arielle/native-libcst-parser branch from 4227a3d to 64099fb Compare March 1, 2023 20:13
@onerandomusername onerandomusername force-pushed the arielle/native-libcst-parser branch from 64099fb to 7be1f20 Compare March 1, 2023 22:43
@shiftinv
Copy link
Member

shiftinv commented Mar 6, 2023

Why not set this globally, similar to PDM_IGNORE_SAVED_PYTHON?

@onerandomusername
Copy link
Member Author

Why not set this globally, similar to PDM_IGNORE_SAVED_PYTHON?

somewhat updated in e77ebc4

noxfile.py Outdated Show resolved Hide resolved
noxfile.py Outdated Show resolved Hide resolved
@shiftinv shiftinv enabled auto-merge (squash) March 16, 2023 16:03
@shiftinv shiftinv merged commit cba829b into master Mar 16, 2023
@shiftinv shiftinv deleted the arielle/native-libcst-parser branch March 16, 2023 16:11
@onerandomusername onerandomusername removed the s: needs review Issue/PR is awaiting reviews label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news t: meta Changes to the project itself (CI, configs, etc.)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants