Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: save the type of response made by an interaction response #737

Merged
merged 9 commits into from
Sep 12, 2022
Merged

feat: save the type of response made by an interaction response #737

merged 9 commits into from
Sep 12, 2022

Conversation

onerandomusername
Copy link
Member

Summary

allows the user to see which kind of response was made to an interaction as this isn't obtainable through the api.

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running task lint
    • I have type-checked the code by running task pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername
feat: save the type of response made by an interaction response
ed74c92
@onerandomusername
fix: remove the redundant _responded attribute
2e8edd3 
not entirely sure about this change.
this keeps the response_type and responded in sync, but this also makes
it a bit harder to check if we've responded, whether we care how we
responded or not. This might be worth of a revert, or even turning
_responded into a property.
@onerandomusername
docs: add changenote
ec9034d
@onerandomusername onerandomusername added t: enhancement New feature s: needs review Issue/PR is awaiting reviews labels Sep 9, 2022
@onerandomusername onerandomusername added this to the disnake v2.6 milestone Sep 9, 2022
shiftinv
shiftinv reviewed Sep 9, 2022
View reviewed changes
disnake/ui/modal.py Outdated Show resolved Hide resolved
shiftinv
shiftinv reviewed Sep 10, 2022
View reviewed changes
disnake/interactions/base.py Outdated Show resolved Hide resolved
changelog/737.feature.rst Outdated Show resolved Hide resolved
@onerandomusername @shiftinv
docs: update wording
9a41b41 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
onerandomusername and others added 2 commits September 12, 2022 12:56
@onerandomusername @shiftinv
bow down to the users who voted
695f1fd 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
@onerandomusername
chore: rename attribute in changelog too
440dc74
@shiftinv shiftinv enabled auto-merge (squash) September 12, 2022 21:06
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Sep 12, 2022
@shiftinv shiftinv merged commit 4f066bc into master Sep 12, 2022
@shiftinv shiftinv deleted the feat/save-response-type branch September 12, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiftinv shiftinv shiftinv approved these changes

Assignees
No one assigned
Labels
t: enhancement New feature
Projects
disnake
Status: Done
Milestone
disnake v2.6
Development

Successfully merging this pull request may close these issues.
2 participants
@onerandomusername @shiftinv