fix: type annotation for View.add_item method#1470
Open
fgfgdfgdfgfdgdf wants to merge 1 commit intoDisnakeDev:masterfrom
Open
fix: type annotation for View.add_item method#1470fgfgdfgdfgfdgdf wants to merge 1 commit intoDisnakeDev:masterfrom
View.add_item method#1470fgfgdfgdfgfdgdf wants to merge 1 commit intoDisnakeDev:masterfrom
Conversation
Signed-off-by: fgfgdfgdfgfdgdf <merzlyakov029@gmail.com>
View.add_item methodView.add_item method
Contributor
|
Does this actually work for doing view = View()
view.add_item(ui.Button())? |
Author
This doesn't work, and pylance gives me an error because the generic type of Item in the add_item method is unknown. If I specify Self or None, there will be no error |
Contributor
I was asking specifically if this works after your fix, but it's clear now it is not as pyright in CI is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes type annotation issue in
View.add_itemmethod where type checkers (Pylance/mypy) reported "Type of 'add_item' is partially unknown" due to missing generic parameter inItemannotation.Checklist
uv run nox -s lintuv run nox -s pyright