Skip to content

feat(user): implement guild tags #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Sep 4, 2025
Merged

feat(user): implement guild tags #1334

merged 28 commits into from
Sep 4, 2025

Conversation

Snipy7374
Copy link
Collaborator

Summary

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@Snipy7374 Snipy7374 added t: enhancement New feature t: api support Support of Discord API features s: needs review Issue/PR is awaiting reviews labels Sep 1, 2025
Enegg
Enegg reviewed Sep 2, 2025
View reviewed changes
Snipy7374 and others added 4 commits September 2, 2025 13:47
@Snipy7374 @Enegg
Update disnake/user.py
0965dbe 
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @Enegg
Update disnake/user.py
65ee494 
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @Enegg
Update disnake/user.py
c55f960 
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @Enegg
Update disnake/user.py
d3bc8db 
Co-authored-by: Eneg <42005170+Enegg@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@shiftinv shiftinv added this to the disnake v2.11 milestone Sep 2, 2025
shiftinv
shiftinv reviewed Sep 3, 2025
View reviewed changes
Snipy7374 and others added 14 commits September 3, 2025 21:00
@Snipy7374 @shiftinv
Update disnake/user.py
bf6ffab 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/user.py
fc0661c 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374 @shiftinv
Update disnake/user.py
c43b89f 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374
rename clan badge to guild tag badge
77793cf
@Snipy7374
move primary_guild on BaseUser
01fd377
@Snipy7374
add primary_guild handling to Member
ab2782f
@Snipy7374
add primary_guild to User internal logic
c46b3e7
@Snipy7374
exclude primary_guild from widgets docs
cc03ea6
@Snipy7374
rename identity_guild_id and remove primary_guild from User slots
daffa20
@Snipy7374
move primary_guild into PartialUser typeddict
5e43281
@Snipy7374
update docs and add PrimaryGuild to user.py __all__
473a138
@Snipy7374
Merge branch 'master' into feat/guild_tags
68bbfb4 
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374
run pre-commit
ad37ee9
@Snipy7374
update internal use to guild_id
cbf48db
shiftinv
shiftinv reviewed Sep 4, 2025
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a couple small fixes, this looks good to me

Snipy7374 and others added 4 commits September 4, 2025 17:08
@Snipy7374 @shiftinv
Update docs/api/users.rst
e9becd8 
Co-authored-by: vi <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: Snipy7374 <100313469+Snipy7374@users.noreply.github.com>
@Snipy7374
update PrimaryGuild repl
b40e1b3
@Snipy7374
add primary_guild to Member type checking clause
b72191b
@Snipy7374
Merge branch 'master' into feat/guild_tags
73ee042
shiftinv
shiftinv approved these changes Sep 4, 2025
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shiftinv shiftinv merged commit 75c6dd8 into DisnakeDev:master Sep 4, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shiftinv shiftinv shiftinv approved these changes

@Victorsitou Victorsitou Awaiting requested review from Victorsitou

+1 more reviewer

@Enegg Enegg Enegg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s: needs review Issue/PR is awaiting reviews t: api support Support of Discord API features t: enhancement New feature

Projects

None yet

Milestone

disnake v2.11

Development

Successfully merging this pull request may close these issues.

implement guild tags (badges)

3 participants

@Snipy7374 @shiftinv @Enegg