Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show the proper permissions in threads #1047

Merged
merged 12 commits into from
Jun 19, 2023
Merged

fix: show the proper permissions in threads #1047

merged 12 commits into from
Jun 19, 2023

Conversation

onerandomusername
Copy link
Member

Summary

fixes permission resolution in threads. This is a short term fix before this is refactored to remove some portions of the implicit permission system

Checklist

  • If code changes were made, then they have been tested
    • I have updated the documentation to reflect the changes
    • I have formatted the code properly by running pdm lint
    • I have type-checked the code by running pdm pyright
  • This PR fixes an issue
  • This PR adds something new (e.g. new method or parameters)
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

@onerandomusername onerandomusername added s: needs review Issue/PR is awaiting reviews t: bugfix labels Jun 12, 2023
@onerandomusername onerandomusername added this to the disnake v2.9 milestone Jun 12, 2023
shiftinv
shiftinv reviewed Jun 15, 2023
View reviewed changes
disnake/abc.py Outdated Show resolved Hide resolved
Sharp-Eyes
Sharp-Eyes suggested changes Jun 18, 2023
View reviewed changes
Copy link
Member

@Sharp-Eyes Sharp-Eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One possible point of improvement, the rest looks fine to me.

disnake/abc.py Show resolved Hide resolved
@onerandomusername onerandomusername force-pushed the fix/permissions-for-context branch from 7f8989e to c724d48 Compare June 18, 2023 22:13
@onerandomusername onerandomusername enabled auto-merge (squash) June 18, 2023 22:19
@shiftinv shiftinv disabled auto-merge June 18, 2023 23:18
shiftinv
shiftinv reviewed Jun 19, 2023
View reviewed changes
changelog/1047.bugfix.rst Outdated Show resolved Hide resolved
disnake/threads.py Outdated Show resolved Hide resolved
@onerandomusername @shiftinv
Update disnake/threads.py
582955c 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arl <me@arielle.codes>
shiftinv
shiftinv approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@shiftinv shiftinv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

onerandomusername and others added 2 commits June 19, 2023 18:39
@onerandomusername @shiftinv
Update changelog/1047.bugfix.rst
bc10cd9 
Co-authored-by: shiftinv <8530778+shiftinv@users.noreply.github.com>
Signed-off-by: arl <me@arielle.codes>
@onerandomusername
Merge branch 'master' into fix/permissions-for-context
4dce02d
@onerandomusername onerandomusername enabled auto-merge (squash) June 19, 2023 22:39
@onerandomusername onerandomusername merged commit 1843145 into master Jun 19, 2023
@onerandomusername onerandomusername deleted the fix/permissions-for-context branch June 19, 2023 23:10
@shiftinv shiftinv removed the s: needs review Issue/PR is awaiting reviews label Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sharp-Eyes Sharp-Eyes Sharp-Eyes requested changes

@shiftinv shiftinv shiftinv approved these changes

@Victorsitou Victorsitou Victorsitou approved these changes

Assignees
No one assigned
Labels
t: bugfix
Projects
disnake
Status: Done
Milestone
disnake v2.9
Development

Successfully merging this pull request may close these issues.
4 participants
@onerandomusername @shiftinv @Sharp-Eyes @Victorsitou