ENG-1503: Replace getFormattedConfigTree consumers with direct helper calls

[sid597]

https://www.loom.com/share/e1bb8573adfe49549013385f6391d21a

---

Summary by CodeRabbit

• Refactor
  • Restructured internal settings access patterns across configuration components, transitioning from legacy config tree retrieval to new helper-based utilities for left sidebar, suggestive mode, export, and general settings management. No user-facing changes; improvements to code maintainability and data flow architecture.

[linear]

ENG-1503 Remove remnants of getFormattedConfigTree

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[devin-ai-integration]

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 3 additional findings.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request refactors settings access patterns across the roam application by systematically replacing direct usage of getFormattedConfigTree with new, specialized helper functions and direct tree access via discourseConfigRef. The changes reorganize how configuration UIDs and values are retrieved and maintain the same behavior through new accessor utilities.

Changes

Cohort / File(s)	Summary
Left Sidebar Configuration apps/roam/src/components/LeftSidebarView.tsx, apps/roam/src/utils/migrateLeftSidebarSettings.ts	Both files transition from getFormattedConfigTree to getLeftSidebarSettings helper for configuration retrieval. Types LeftSidebarConfig and LeftSidebarPersonalSectionConfig are imported from new location ~/utils/getLeftSidebarSettings.
Settings Components apps/roam/src/components/settings/AdminPanel.tsx, apps/roam/src/components/settings/ExportSettings.tsx, apps/roam/src/components/settings/GeneralSettings.tsx, apps/roam/src/components/settings/SuggestiveModeSettings.tsx	Replace getFormattedConfigTree with new specific helpers (getExportSettingsAndUids, getSuggestiveModeConfigAndUids) and direct discourseConfigRef.tree access. Introduce new utility imports (getPageUidByPageTitle, getUidAndBooleanSetting, getUidAndStringSetting, DISCOURSE_CONFIG_PAGE_TITLE) to compute UID references explicitly.
Core Settings Infrastructure apps/roam/src/components/settings/Settings.tsx, apps/roam/src/components/settings/utils/accessors.ts	Update configuration node lookups to use discourseConfigRef.tree directly and introduce nullish-aware access patterns. Refactor legacy feature flag readers to use getUidAndBooleanSetting with new tree-based approach.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• ENG-851 Get left sidebar sections and settings from config page #439 — Adds and adopts getLeftSidebarSettings and LeftSidebarConfig that this PR now consumes across multiple components for left-sidebar configuration sourcing.
• Roam: ENG-709: Settings panel for suggestive mode #327 — Introduces getSuggestiveModeConfigAndUids helper and related suggestive-mode configuration utilities that this PR leverages in settings components.
• ENG-1468: Port node and relations tree based consumers #825 — Performs the same refactor pattern of replacing getFormattedConfigTree with centralized accessor helpers throughout settings-related code.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective of the PR: replacing getFormattedConfigTree consumers with direct helper calls, which is reflected across all modified files.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[mdroidian]

I won't block on this, but most of these changes look like they use the same functions that getFormattedConfigTree was using. If so, how is this an improvement? I was under the impression the removal of getFormattedConfigTree was to consolidate under dual read. But these changes are effectively the same behavior/logic as previously? It actually seems like these changes will make it more difficult to fully migrate (we'll have to look for many more smaller generic functions, rather than one function)

Can you help me understand what the purpose/benefit of these changes are?

[sid597]

So the idea is that depending on how we're going to clean up the functions, if we want to clean up by an individual component, we had to remove getFormattedConfigTree. This is because it could be used on multiple components in a single file but also because we cannot remove just a single. It could be the case that if we move a single key when we're trying to clean up that entire tree of components somewhere else in the repo could use that key, which would then break and go outside of the scope of what we're trying to clean up.