ENG-1479: Port suggestive mode settings to dual-read

[sid597]

https://www.loom.com/share/6b740485161741e8b5ddd7d58b5f9891

---

Summary by CodeRabbit

• Refactor
  • Updated feature flag access to use a centralized mechanism with diagnostic support for configuration compatibility.
  • Streamlined how settings are retrieved across the admin panel and suggestive mode components.

[linear]

ENG-1479 Port suggestive mode settings to dual-read

[supabase]

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[sid597]

@coderabbitai full review

[coderabbitai]

✅ Actions performed

Full review triggered.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR migrates feature flag access from legacy config-tree paths to a centralized mechanism via getFeatureFlag(). The new function provides dual-read support with fallback logic: it checks a legacy mapping first, then reads from block-props, and logs mismatches when both sources exist. Components across settings UI and initialization code are updated to use this new accessor instead of direct config tree reads.

Changes

Cohort / File(s)	Summary
Feature Flag Accessor Layer apps/roam/src/components/settings/utils/accessors.ts	Added new getFeatureFlag() function implementing dual-read logic with legacy-map fallback, mismatch diagnostics, and support for "Suggestive mode enabled" and "Enable left sidebar" flags.
Feature Flag Migrations apps/roam/src/components/settings/AdminPanel.tsx, apps/roam/src/index.ts	Replaced direct settings.suggestiveModeEnabled.value and Roam config-tree reads with getFeatureFlag("Suggestive mode enabled") for centralized flag access.
Settings Accessor Migrations apps/roam/src/components/settings/SuggestiveModeSettings.tsx, apps/roam/src/utils/hyde.ts	Updated to use getGlobalSetting() for retrieving boolean settings ("Include current page relations", "Include parent and child blocks") instead of legacy extension-API or direct initialValue reads.

Sequence Diagram

sequenceDiagram
    participant Component as Component<br/>(e.g., AdminPanel)
    participant getFeatureFlag as getFeatureFlag()<br/>Accessor
    participant LegacyMap as FEATURE_FLAG_LEGACY_MAP
    participant BlockProps as getFeatureFlags()<br/>(Block Props)
    participant LegacyConfig as getFormattedConfigTree()<br/>(Legacy Config)

    Component->>getFeatureFlag: getFeatureFlag(key)
    getFeatureFlag->>LegacyMap: Check if legacy reader exists
    alt Legacy reader found
        LegacyMap-->>getFeatureFlag: Legacy reader fn
        getFeatureFlag->>BlockProps: getFeatureFlags()
        BlockProps-->>getFeatureFlag: blockPropsValue
        alt New settings store enabled
            getFeatureFlag->>LegacyConfig: Call legacy reader fn
            LegacyConfig-->>getFeatureFlag: legacyValue
            alt Values mismatch
                getFeatureFlag->>getFeatureFlag: Log mismatch warning
            end
            getFeatureFlag-->>Component: Return blockPropsValue
        else Legacy settings only
            getFeatureFlag-->>Component: Return legacyValue
        end
    else No legacy reader
        getFeatureFlag->>BlockProps: getFeatureFlags()
        BlockProps-->>getFeatureFlag: value
        getFeatureFlag-->>Component: Return value
    end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• ENG-993 Move sync settings to tabs #514 — Both PRs modify SuggestiveModeSettings.tsx and update how the includePageRelations flag and related state initialization are handled.
• ENG-1112: add suggestive mode flag and settings to admin panel #589 — Both PRs update AdminPanel.tsx to use the centralized getFeatureFlag() mechanism and touch suggestive-mode flag sourcing.
• Roam: Eng-749 hyde functionality #344 — Both PRs modify apps/roam/src/utils/hyde.ts to replace legacy extension-API flag reads with new global-setting accessors.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title directly and specifically describes the main change: porting suggestive mode settings to a dual-read mechanism. It aligns with the PR's core objective of implementing dual-read logic for feature flags with legacy support.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}