ENG-1373: Drag pages onto the canvas to create node shapes#1083
Conversation
Page refs aren't draggable by default, so make them draggable via the existing rm-page-ref observer and route the drag payload through the canvas text-content handler that already turns [[name]] into a discourse-node shape. - Always-on: only the draggable attribute is global; the drag payload and drop handling live in the canvas component, so drags are inert unless a canvas is open. - Custom MIME (application/x-roam-page), not text/plain, so a drag can't leak [[title]] into other blocks or apps. - Guard the existing block-dragstart so dragging a ref doesn't also attach its containing block's UID.
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 014d57e942
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| onPageRefObserverChange(overlayHandler)(true); | ||
| } | ||
|
|
||
| onPageRefObserverChange(makePageRefDraggable)(true); |
There was a problem hiding this comment.
Enabling onPageRefObserverChange(makePageRefDraggable)(true) unconditionally at startup makes every .rm-page-ref in Roam draggable, not just refs involved in canvas drops. In practice this changes normal editor behavior: click-drag gestures on page refs (including in regular blocks) start HTML drag operations, which interferes with expected text selection/editing flows outside the canvas. This regression is user-facing across the app and should be gated to canvas-specific contexts or a dedicated drag handle.
Useful? React with 👍 / 👎.
The always-on registration had no matching teardown, so the singleton rm-page-ref observer and the makePageRefDraggable callback survived extension unload/reload. Add a cleanup that unregisters the handler; for users without the overlay/preview/suggestive handlers this empties the set and disconnects the observer.
1 participant
No description provided.