Skip to content

ENG-1701: basic-group-management-ui#1057

Open
maparent wants to merge 5 commits into
mainfrom
eng-1701-basic-group-management-ui
Open

ENG-1701: basic-group-management-ui#1057
maparent wants to merge 5 commits into
mainfrom
eng-1701-basic-group-management-ui

Conversation

@maparent
Copy link
Copy Markdown
Collaborator

@maparent maparent commented May 20, 2026

@linear-code
Copy link
Copy Markdown

linear-code Bot commented May 20, 2026

ENG-1701

@supabase
Copy link
Copy Markdown

supabase Bot commented May 20, 2026

This pull request has been ignored for the connected project zytfjzqyijgagqxrzbmz because there are no changes detected in packages/database/supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@maparent maparent force-pushed the eng-1701-basic-group-management-ui branch 6 times, most recently from 5199bfb to c4832f1 Compare May 21, 2026 17:58
@maparent maparent changed the base branch from ENG-1723-list-group-members-linearized to main May 21, 2026 21:30
@maparent maparent force-pushed the eng-1701-basic-group-management-ui branch from bb72695 to 71cb3be Compare May 25, 2026 13:52
@maparent maparent changed the title ENG-1701: UI by claude (with guidance) ENG-1701: basic-group-management-ui May 25, 2026
@maparent maparent marked this pull request as ready for review May 25, 2026 14:36
@graphite-app
Copy link
Copy Markdown
Contributor

graphite-app Bot commented May 25, 2026

PR size/scope check

This PR is over our review-size guideline.

  • Recommended: ~200 lines changed
  • Acceptable limit: up to 400 lines when well-scoped/self-contained
  • Preferred file count: fewer than 5 files

Please split this into smaller PRs unless there is a clear reason the changes need to land together.

If keeping it as one PR, please add a brief justification covering:

  • What single problem this PR solves
  • Why the files/changes are coupled

Comment thread apps/website/app/components/auth/CreateGroup.tsx Outdated
@maparent
Copy link
Copy Markdown
Collaborator Author

Interesting anomaly: I had lint errors from the GitHub task of the form

Warning:   38:20  warning  Promise-returning function provided to attribute where a void return was expected  @typescript-eslint/no-misused-promises```
(Because I was using async functions directly as actions instead of wrapping them with a void.)
But those lint errors did not show up in a local `pnpm run lint`. Are the settings different in any way?

@maparent maparent requested review from mdroidian and removed request for mdroidian May 25, 2026 14:54
@maparent maparent force-pushed the eng-1701-basic-group-management-ui branch from 54a11b8 to fbfe8fa Compare May 25, 2026 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant