Bi-directional layout support #736
Conversation
|
To answer your questions:
left should mean left, etc.
My intuition on this is that it should happen during the calculations. But I would be open to being persuaded otherwise. As long as whichever implementation we choose is able to pass all the relevant tests and match other browsers I think I'll be happy. Will do a proper review later. |
There was a problem hiding this comment.
@tjamaan Actual direction changes look good to me. But we'll want to hook this up to our testing infrastructure to verify that. The process for that is something like:
- Add support for the
directionproperty to ourgentestscript- Add support for reading it to
scripts/gentest/test_helper.js - Add support for generating to
scripts/gentest/main.rs
- Add support for reading it to
- Setup the gentest script to generate every test with both
ltrandrtlas the default. - Write some new tests to test mixed direction.
I've also formatted main using the latest nightly, and I've also removed .cargo/config from our repo. So if you rebase on latest main that should get rid of a bunch of unrelated changes from the diff.
| /// TODO: documentation | ||
| pub direction: Direction, |
There was a problem hiding this comment.
Am I correct in thinking that this isn't actually used? If so, it should probably be removed. Removing the direction field here and the direction function parameter from the traits would greatly reduce the size of the diff for this PR which would be nice!
| match direction { | ||
| Direction::Rtl => { | ||
| justify_content.flip(); | ||
| justify_items.as_mut().map(|x| x.flip()); | ||
| } | ||
| _ => (), | ||
| } |
There was a problem hiding this comment.
Maybe use if direction.is_rtl() here?
Objective
Add support for bi-directional layout (left-to-right and right-to-left) via the
directionCSS style property.Context
This change attempts to support bidi layout only for horizontal layout direction, i.e. it doesn't support vertical content such as CJK or Mongolian vertical writing systems.
Feedback wanted
Should inset, margin, padding, and border
Rects be considered as absolute axis (left means left and right means right) or relative axis (left means layout start, right means layout end)?Should the RTL conversion happen during the calculations or as a separate phase (i.e. calculate as if LTR then flip the horizontal axis)?
General code review is also wanted to be more aligned with the rest of taffy's code :)