Switch to a const hash instead of comparing pointers for template diffing#5276
Open
ealmloff wants to merge 4 commits intoDioxusLabs:mainfrom
Open
Switch to a const hash instead of comparing pointers for template diffing#5276ealmloff wants to merge 4 commits intoDioxusLabs:mainfrom
ealmloff wants to merge 4 commits intoDioxusLabs:mainfrom
Conversation
ealmloff
added
bug
ealmloff
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we compare templates in two different ways depending on the opt level of dioxus-core:
This causes issues if dioxus-core is built at a higher level than dioxus itself.
This PR changes the comparison to always compare by a hash which is created at compile time for const templates (or at runtime for hot reloaded templates). Unfortunately, this requires a new field on template which previously only had public fields which makes this change breaking.
Fixes #5274