Get wasm bindgen working on desktop#5194
Open
ealmloff wants to merge 68 commits intoDioxusLabs:mainfrom
Open
Conversation
ealmloff
commented
Jan 14, 2026
| let form_element = self | ||
| .element | ||
| .dyn_ref::<web_sys_x::HtmlFormElement>() | ||
| .cloned() |
Member
Author
There was a problem hiding this comment.
This was the existing behavior we tested for in dioxus desktop
Member
Author
CI is running out of storage with the new crates this PR adds. Running locally on linux gnu, the same tests pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for a fork of wasm bindgen, web sys and js sys. It moves the virtual dom to a separate thread from the event loop. This lets us share a lot more code between desktop and web including the logic for:
Breaking changes
web-sys-xtypes which usewasm-bindgen-xfor desktop compatibilitySendbound. This breaks a couple of examplesStatus of wasm-bindgen-x
Where we still aren't compatible with wasm-bindgen:
memory()wasm_bindgen::convertPublishing:
An initial version is published here which works for dioxus' use cases without a patch. For patching it may be easier to rely on the git tag instead as cargo doesn't let you patch to the same source without a registry alias.
The current published version of web-sys-x has only a limited number of features because of the crates.io limit of 300 features per crate. I have reached out to the crates.io team to see if we can remove that limit to publish the full version
TODO
Partially addresses #4142 since
as_web_eventnow works on desktop and mobile