Skip to content

Fix is_release_profile Logic #4091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 15, 2025

Conversation

LeWimbes
Copy link
Contributor

@LeWimbes LeWimbes commented May 8, 2025

This PR addresses two bugs in the is_release_profile function:

  1. When using the default release profile, the function returned false because the loop was never entered.
  2. The function never explicitly checked if the current_profile_name itself is "release".

With this patch, we:

  • Immediately return true if profile == "release".
  • After following an inheritance chain, also return true if we ever encounter "release".

Closes #4018.

@LeWimbes LeWimbes requested a review from a team as a code owner May 8, 2025 09:53
@jkelleyrtp
Copy link
Member

Thank you! I had to fix a few other things and pushed them to your branch :)

@jkelleyrtp jkelleyrtp merged commit 18477a0 into DioxusLabs:main May 15, 2025
17 checks passed
@LeWimbes LeWimbes deleted the dx-bundle-debug-release branch May 15, 2025 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dx bundle defaults to "release", but claims not to
2 participants