Skip to content

fix(vdom): try to fix vdom panic - #1496

Closed
sdwoodbury wants to merge 1 commit into
DioxusLabs:masterfrom
sdwoodbury:fix/vdom-panic
Closed

fix(vdom): try to fix vdom panic#1496
sdwoodbury wants to merge 1 commit into
DioxusLabs:masterfrom
sdwoodbury:fix/vdom-panic

Conversation

@sdwoodbury

Copy link
Copy Markdown
Contributor

the Uplink project was experiencing a panic on this line. I'm not sure if this is a valid way to fix the issue. The panic happened because attr_paths was empty when dynamic_attrs wasn't.

@ealmloff

Copy link
Copy Markdown
Member

the Uplink project was experiencing a panic on this line. I'm not sure if this is a valid way to fix the issue. The panic happened because attr_paths was empty when dynamic_attrs wasn't.

This might fix the panic, but it points to a larger issue: the template and dynamic_attrs are either pointing to two different rsx calls or one of them is being generated incorrectly in the macro. Do you know what changes in Uplink that triggered this issue? I could take a look to see if there is anything unique that could trigger a bug in Dioxus

@sdwoodbury

Copy link
Copy Markdown
Contributor Author

@ealmloff I'm not sure what might have triggered the issue but there have been a lot of seemingly minor updates to Uplink. It apparently happens only on Windows, after logging in, and was noticed as early as sept 21. I'm looking through the code. haven't found anything blatantly wrong yet.

@ealmloff

ealmloff commented Sep 29, 2023

Copy link
Copy Markdown
Member

#1402 seems to fix this issue

@ealmloff ealmloff closed this Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants