Skip to content

Reduce embedded and express to separate JS files #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Reduce embedded and express to separate JS files #215

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ae94fc
Reduce embedded and express to separate JS files
mntzrr Jun 3, 2025
f5222ea
Remove unused variable
mntzrr Jun 4, 2025
bb402c0
Merge branch 'develop' into develop-separate-checkout-js
mntzrr Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions assets/js/dintero-checkout-express.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ jQuery( function ( $ ) {
return
}

const gatewayParams = dinteroCheckoutParams

const dinteroCheckoutForWooCommerce = {
bodyEl: $( "body" ),
checkoutFormSelector: "form.checkout",
Expand Down Expand Up @@ -81,7 +79,13 @@ jQuery( function ( $ ) {
* Render the iframe and register callback functionality.
*/
async renderIframe() {
const container = $( "#dintero-checkout-iframe" )[ 0 ]
const iframeElement = $( "#dintero-checkout-iframe" )
const container = iframeElement.length ? iframeElement[ 0 ] : null

if ( ! container ) {
console.error( "Dintero Checkout: Could not find the container for the iframe." )
return
}

dintero
.embed( {
Expand Down
Loading